Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry #655

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Add telemetry #655

merged 4 commits into from
Sep 25, 2023

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Sep 20, 2023

Resolves #432

Note: there are currently some issues with the backend. The PR can be reviewed but shouldn't be merged until the backend issues are resolved.

@erri120 erri120 added this to the v0.2 milestone Sep 20, 2023
@erri120 erri120 requested a review from a team September 20, 2023 10:27
@erri120 erri120 self-assigned this Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #655 (d0be2d8) into main (1fa75bf) will decrease coverage by 0.03%.
Report is 10 commits behind head on main.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
- Coverage   64.09%   64.06%   -0.03%     
==========================================
  Files         617      622       +5     
  Lines       17401    17508     +107     
  Branches     1115     1120       +5     
==========================================
+ Hits        11153    11217      +64     
- Misses       5970     6009      +39     
- Partials      278      282       +4     
Flag Coverage Δ
Linux 63.44% <80.00%> (+0.17%) ⬆️
Windows 63.21% <80.00%> (-0.11%) ⬇️
clean_environment_tests 64.06% <80.00%> (-0.03%) ⬇️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
src/NexusMods.App/Program.cs 0.00%
src/NexusMods.App/Telemetry.cs 47.36%
src/NexusMods.App/AppConfig.cs 100.00%
src/NexusMods.App/Services.cs 100.00%
....DataModel/GlobalSettings/GlobalSettingsManager.cs 100.00%
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'm not particularly knowledgeable on this

@Sewer56
Copy link
Member

Sewer56 commented Sep 20, 2023

Did look good to me, I just didn't comment because it'l labeled 'no merge'

@erri120
Copy link
Member Author

erri120 commented Sep 21, 2023

The PR can now be merged.

@halgari halgari merged commit 3def00d into Nexus-Mods:main Sep 25, 2023
6 of 7 checks passed
@erri120 erri120 deleted the issue-432-telemetry branch September 25, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants