-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove analyzers #615
Remove analyzers #615
Conversation
…stry that needs fixing
Codecov Report
@@ Coverage Diff @@
## main #615 +/- ##
=========================================
+ Coverage 0 64.03% +64.03%
=========================================
Files 0 615 +615
Lines 0 17335 +17335
Branches 0 1102 +1102
=========================================
+ Hits 0 11101 +11101
- Misses 0 5962 +5962
- Partials 0 272 +272
Flags with carried forward coverage won't be shown. Click here to find out more. |
This PR conflicts with |
src/Games/NexusMods.Games.BethesdaGameStudios/PluginAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Games/NexusMods.Games.Generic/Installers/GenericFolderMatchInstaller.cs
Show resolved
Hide resolved
...sMods.Games.BethesdaGameStudios.Tests/SkyrimSpecialEditionTests/SkyrimSpecialEditionTests.cs
Outdated
Show resolved
Hide resolved
tests/Games/NexusMods.Games.StardewValley.Tests/Analyzers/SMAPIManifestAnalyzerTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of broken XML/Documentation tags introduced in this PR, such as in the Entity
class' documentation. Either leading to types that no longer exist, or to parameters that no longer exist. Please review these (check the Warnings tab), before merging too.
# Conflicts: # src/Games/NexusMods.Games.FOMOD/FomodXmlInstaller.cs
This PR doesn't conflict with |
This code removes analyzers from the codebase.
Now that we have fast access to files whenever we need, we can analyze on-the-fly. This PR: