Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove analyzers #615

Merged
merged 53 commits into from
Sep 18, 2023
Merged

Remove analyzers #615

merged 53 commits into from
Sep 18, 2023

Conversation

halgari
Copy link
Collaborator

@halgari halgari commented Sep 7, 2023

This code removes analyzers from the codebase.

Now that we have fast access to files whenever we need, we can analyze on-the-fly. This PR:

  • Adds a IDownloadRegistry for tracking download metadata (separate from archive storage)
  • Removes IFileAnalyzer
  • Removes IArchiveAnalyzer
  • Reworks all installers to use FileTree and to do analysis locally
  • Delete inlined analyzers
  • Complex analyzers are either static classes or new DI components, but without IFileAnalyzer
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #615 (0c573bd) into main (8e53f4b) will increase coverage by 64.03%.
The diff coverage is 75.07%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #615       +/-   ##
=========================================
+ Coverage      0   64.03%   +64.03%     
=========================================
  Files         0      615      +615     
  Lines         0    17335    +17335     
  Branches      0     1102     +1102     
=========================================
+ Hits          0    11101    +11101     
- Misses        0     5962     +5962     
- Partials      0      272      +272     
Flag Coverage Δ
Linux 63.34% <75.07%> (?)
Windows 63.21% <75.07%> (?)
clean_environment_tests 64.02% <75.07%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
...ds.Games.BethesdaGameStudios/PluginAnalysisData.cs ø
...exusMods.Games.DarkestDungeon/Models/ModProject.cs ø
...c/Games/NexusMods.Games.DarkestDungeon/Services.cs ø
src/Games/NexusMods.Games.FOMOD/Services.cs ø
...ods.Games.Generic/FileAnalyzers/IniAnalysisData.cs 0.00%
...xusMods.Games.Generic/FileAnalyzers/IniAnalzyer.cs 0.00%
src/Games/NexusMods.Games.Generic/Services.cs ø
src/Games/NexusMods.Games.RedEngine/Services.cs ø
...usMods.Games.StardewValley/Models/SMAPIManifest.cs ø
...rc/Games/NexusMods.Games.StardewValley/Services.cs ø
... and 63 more
@halgari halgari requested a review from a team September 12, 2023 20:56
@halgari halgari changed the title WIP: Remove analyzers Sep 12, 2023
@github-actions
Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of broken XML/Documentation tags introduced in this PR, such as in the Entity class' documentation. Either leading to types that no longer exist, or to parameters that no longer exist. Please review these (check the Warnings tab), before merging too.

@github-actions
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@halgari halgari merged commit 9d57ff1 into main Sep 18, 2023
7 checks passed
@halgari halgari deleted the remove-analyzers branch September 18, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants