Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOMOD validation for CLI #608

Merged
merged 5 commits into from
Sep 5, 2023
Merged

FOMOD validation for CLI #608

merged 5 commits into from
Sep 5, 2023

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Sep 5, 2023

  • Added static GuidedInstallerValidation class containing two static validation methods, one for a single group, one for an entire step.

  • Adds checks before proceeding with steps to make sure each group selection respects the requirements of the group (At least one, at most one, exactly one).

  • Fixed Fomod installer creating GamePaths using unsanitized paths.

@Al12rs Al12rs requested a review from erri120 September 5, 2023 10:03
@Al12rs Al12rs added this to the v0.2 milestone Sep 5, 2023
@Al12rs Al12rs self-assigned this Sep 5, 2023
@erri120 erri120 changed the title Fomd validation for CLI Sep 5, 2023
@erri120 erri120 linked an issue Sep 5, 2023 that may be closed by this pull request
- Avoid unneccessary conversions
- Use IReadOnlyCollection as inputs
@Al12rs Al12rs requested a review from erri120 September 5, 2023 11:57
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #608 (34de8b0) into main (3680f83) will increase coverage by 67.85%.
The diff coverage is 44.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #608       +/-   ##
=========================================
+ Coverage      0   67.85%   +67.85%     
=========================================
  Files         0      600      +600     
  Lines         0    16512    +16512     
  Branches      0     1103     +1103     
=========================================
+ Hits          0    11205    +11205     
- Misses        0     5026     +5026     
- Partials      0      281      +281     
Flag Coverage Δ
Linux 67.08% <44.23%> (?)
Windows 66.96% <44.23%> (?)
clean_environment_tests 67.85% <44.23%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
src/NexusMods.CLI/CliGuidedInstaller.cs 0.00%
...c/Games/NexusMods.Games.FOMOD/FomodXmlInstaller.cs 80.00%
...GuidedInstaller/GuidedInstallationStepValidator.cs 100.00%
@Al12rs Al12rs merged commit b6e4095 into main Sep 5, 2023
6 checks passed
@Al12rs Al12rs deleted the fomd-validation branch September 5, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants