-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented localization support throughout the app #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed CreateBinding to CreateAvaloniaBinding - Updated LaunchButtonViewModel translations to be dynamic
- ToolManger - StringFormatter
…ing the locale after each test
…ateAvaloniaBinding
This reverts commit 8d23cf3dcd09eab12bf65523e9eca327631f8a16.
This reverts commit 145cc6a0809594b768ba51c1dfe8d5cbf5a5c52d.
Codecov Report
@@ Coverage Diff @@
## main #587 +/- ##
==========================================
- Coverage 68.12% 67.85% -0.27%
==========================================
Files 599 599
Lines 16222 16465 +243
Branches 1086 1098 +12
==========================================
+ Hits 11051 11173 +122
- Misses 4895 5010 +115
- Partials 276 282 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
This is a lot of mind-numbing work. Thanks for cranking through all this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #453
I tried finding all of the string, but I might have missed some.