Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner for development builds (#567) #574

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

JonathanFeenstra
Copy link
Contributor

This adds a banner at the bottom of the screen to show that the current build is a development/debug build as described in #567. In case of a debug build, it looks like this:

Screenshot 2023-08-24 231037

In case of an official (pre-)release, it shows the product version instead of the "Debug build" text.

For now, the banner is hard-coded into the MainWindow as discussed on Discord. This means the code needs to be removed before making a stable release, or updated to only display the banner if a stable release version is detected. The text is also hard-coded an not localised.

I noticed that Rider automatically made some whitespace changes in IconStyles.xaml. Let me know if I should remove those from the commit.

@JonathanFeenstra
Copy link
Contributor Author

Note that this does not fully resolve #476 since the banner is only shown for development builds. For stable releases, it would still make sense to display the version elsewhere in the UI.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #574 (185d200) into main (f776c9d) will increase coverage by 68.09%.
The diff coverage is 94.44%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #574       +/-   ##
=========================================
+ Coverage      0   68.09%   +68.09%     
=========================================
  Files         0      599      +599     
  Lines         0    16222    +16222     
  Branches      0     1086     +1086     
=========================================
+ Hits          0    11047    +11047     
- Misses        0     4895     +4895     
- Partials      0      280      +280     
Flag Coverage Δ
Linux 67.33% <94.44%> (?)
Windows 67.26% <94.44%> (?)
clean_environment_tests 68.09% <94.44%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/NexusMods.App.UI/Theme/IconStyles.xaml 97.14% <66.66%> (ø)
...entBuildBanner/DevelopmentBuildBannerView.axaml.cs 92.30% <92.30%> (ø)
...opmentBuildBanner/DevelopmentBuildBannerView.axaml 100.00% <100.00%> (ø)
src/NexusMods.App.UI/Services.cs 97.82% <100.00%> (ø)
src/NexusMods.App.UI/Windows/MainWindow.axaml 100.00% <100.00%> (ø)
src/NexusMods.App.UI/Windows/MainWindow.axaml.cs 85.00% <100.00%> (ø)
...rc/NexusMods.App.UI/Windows/MainWindowViewModel.cs 74.03% <100.00%> (ø)

... and 592 files with indirect coverage changes

@halgari
Copy link
Collaborator

halgari commented Aug 24, 2023

For now, all builds are development, so this is fantastic. Thanks for the contribution!

@halgari halgari merged commit bdb8a2c into Nexus-Mods:main Aug 24, 2023
6 checks passed
@JonathanFeenstra JonathanFeenstra deleted the devbuild-banner branch August 26, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants