Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer Architecture Revamp #573

Merged
merged 12 commits into from
Aug 24, 2023
Merged

Conversation

halgari
Copy link
Collaborator

@halgari halgari commented Aug 24, 2023

resolves: #489

Reworks mod installers, so that they are no longer global, but come from a sorted list on the game itself. Also removes the no longer needed capabilities system. Instead now, information for each installer is added to it via the game that creates the installer.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #573 (50061dd) into main (b34be79) will decrease coverage by 0.12%.
Report is 5 commits behind head on main.
The diff coverage is 77.41%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
- Coverage   68.14%   68.02%   -0.12%     
==========================================
  Files         602      597       -5     
  Lines       16204    16188      -16     
  Branches     1103     1085      -18     
==========================================
- Hits        11042    11012      -30     
- Misses       4876     4900      +24     
+ Partials      286      276      -10     
Flag Coverage Δ
Linux 67.24% <77.41%> (-0.12%) ⬇️
Windows 67.19% <77.41%> (-0.12%) ⬇️
clean_environment_tests 68.02% <77.41%> (-0.12%) ⬇️
network_tests ?
networking_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/NexusMods.Games.DarkestDungeon/DarkestDungeon.cs 43.75% <0.00%> (-5.09%) ⬇️
...arkestDungeon/Installers/LooseFilesModInstaller.cs 100.00% <ø> (ø)
...es.DarkestDungeon/Installers/NativeModInstaller.cs 92.59% <0.00%> (-0.75%) ⬇️
src/Games/NexusMods.Games.FOMOD/Services.cs 100.00% <ø> (ø)
src/Games/NexusMods.Games.Generic/Services.cs 100.00% <ø> (ø)
...c/Games/NexusMods.Games.RedEngine/Cyberpunk2077.cs 66.66% <0.00%> (-17.95%) ⬇️
...ames.StardewValley/Installers/SMAPIModInstaller.cs 92.30% <0.00%> (-0.80%) ⬇️
...c/NexusMods.DataModel/Games/Unknown/UnknownGame.cs 21.73% <0.00%> (-4.35%) ⬇️
...sMods.StandardGameLocators.TestHelpers/Services.cs 100.00% <ø> (ø)
...s.TestHelpers/StubbedGames/StubbedGameInstaller.cs 100.00% <ø> (+4.00%) ⬆️
... and 18 more

... and 11 files with indirect coverage changes

Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
To note, this creates direct dependencies between each game project and whatever installer projects they are using.
Once we will get to the point of having games or installers not hosted in the same solution this could become less desirable.

@halgari halgari merged commit f776c9d into main Aug 24, 2023
6 of 7 checks passed
@halgari halgari deleted the 489-installer-architecture-revamp branch August 24, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants