-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installer Architecture Revamp #573
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
==========================================
- Coverage 68.14% 68.02% -0.12%
==========================================
Files 602 597 -5
Lines 16204 16188 -16
Branches 1103 1085 -18
==========================================
- Hits 11042 11012 -30
- Misses 4876 4900 +24
+ Partials 286 276 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
To note, this creates direct dependencies between each game project and whatever installer projects they are using.
Once we will get to the point of having games or installers not hosted in the same solution this could become less desirable.
resolves: #489
Reworks mod installers, so that they are no longer global, but come from a sorted list on the game itself. Also removes the no longer needed capabilities system. Instead now, information for each installer is added to it via the game that creates the installer.