Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide remaining time in UI when paused #571

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

JanuarySnow
Copy link
Contributor

closes #510

Hides the UI element text for time remaining when throughput is effectively zero (paused)

Thought it was better hidden rather than saying "0 seconds remaining" which might be a bit misleading.

Normal:

unpaused

Paused:

paused

@Sewer56
Copy link
Member

Sewer56 commented Aug 23, 2023

CC @captainsandypants (<= UX/design).


The code part is fine, because paused jobs return AdditiveIdentity as their throughput (i.e. 0).

Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is OK, however please don't merge without input from design.

@JanuarySnow
Copy link
Contributor Author

Updated test code to check for the empty string instead of the numerical value when downloads are paused

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #571 (f95ee7e) into main (b34be79) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   68.14%   68.14%   -0.01%     
==========================================
  Files         602      602              
  Lines       16204    16213       +9     
  Branches     1103     1104       +1     
==========================================
+ Hits        11042    11048       +6     
  Misses       4876     4876              
- Partials      286      289       +3     
Flag Coverage Δ
Linux 67.42% <100.00%> (+0.05%) ⬆️
Windows 67.24% <100.00%> (-0.07%) ⬇️
clean_environment_tests 68.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ightContent/Downloads/InProgressCommonViewModel.cs 98.29% <100.00%> (ø)
....UI/RightContent/Downloads/InProgressView.axaml.cs 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

@Al12rs Al12rs merged commit 61de8b0 into Nexus-Mods:main Aug 24, 2023
5 of 6 checks passed
@Al12rs
Copy link
Contributor

Al12rs commented Aug 24, 2023

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants