Allow games to set target path for Fomod installer #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om it. - Add Common capabilities to ABethesdaGame
Al12rs
added
the
BLOCKED
erri120
requested changes
Aug 10, 2023
...s/NexusMods.Games.BethesdaGameStudios/Capabilities/BethesdaFolderMatchInstallerCapability.cs
Outdated
Show resolved
Hide resolved
| @@ -35,6 +35,7 @@ public CommandLineConfigurator(IEnumerable<RegisteredVerb> verbs, IServiceProvid | |||
| _provider = provider; | |||
| _verbs = verbs.ToArray(); | |||
| _getOptionMethod = typeof(CommandLineConfigurator).GetMethod(nameof(GetOption), BindingFlags.Instance | BindingFlags.NonPublic)!; | |||
| selector.Renderer = _defaultConsoleRenderer; | |||
Comment on lines
+53
to
+58
| else | ||
| { | ||
| var selector = host.Services.GetRequiredService<CliOptionSelector>(); | ||
| var renderers = host.Services.GetServices<IRenderer>(); | ||
| selector.Renderer = renderers.FirstOrDefault(r => r.Name == "console") ?? renderers.First(); | ||
| } |
|
Thanks for reviewing, that's great feedback! |
- Use safe cast in case someone added a capability using the wrong ID.
erri120
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #431
Fomod installer now installs to GamePathType.Game by default unless games specify a different path using a capability.
To simplify making changes for all Bethesda games I also added
ABethesdaGame, and made the two skyrim games inherit from it.Also did a bit of cleanup of capabilities related code.
! Requires #540 to be merged first (this is already rebased on those changes).