-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure INI parser to support bethesda ini files #535
Conversation
Should probably add some tests for this. |
Something like installing a mod with a "bad" ini file? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have some tests for the config.
You can make the settings object internal and create a test that has various void Test_IniParser()
{
const string ini = @"
# this is a comment
foo = bar
";
//...
} |
That assumes I know all the "interesting" cases for inis to fail. What are we checking for exactly? |
On |
Added a test for this |
* Configure INI parser to support bethesda ini files. Configuration taken from Mutagen: https://github.com/Noggog/Mutagen/blob/369a0549fab90593cb130b3889f988228f8ecf98/Mutagen.Bethesda.Core/Archives/DI/GetArchiveIniListings.cs#L38-L46 * Add test for INI parsing
fixes #448
Configuration taken from Mutagen:
https://github.com/Noggog/Mutagen/blob/369a0549fab90593cb130b3889f988228f8ecf98/Mutagen.Bethesda.Core/Archives/DI/GetArchiveIniListings.cs#L38-L46
Tested with ENB for Legendary edition.