Add tests that cover installing most popular mods for Skyrim LE/SE #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix NxmDownloadProtocolHandler ignoring passed modName. # Conflicts: # src/NexusMods.CLI/Verbs/DownloadAndInstallMod.cs
- Installs SKSE, Skyui, USLEP and check if everything went well.
- Install SKSE64, Skyui, USSEP and check if everything went well - Some code formatting
erri120
requested changes
Aug 8, 2023
...s.Games.BethesdaGameStudios.Tests/SkyrimLegendaryEditionTests/SkyrimLegendaryEditionTests.cs
Outdated
Show resolved
Hide resolved
...sMods.Games.BethesdaGameStudios.Tests/SkyrimSpecialEditionTests/SkyrimSpecialEditionTests.cs
Outdated
Show resolved
Hide resolved
erri120
approved these changes
Aug 8, 2023
|
CI doesn't appear to like the new tests, they work fine locally. |
halgari
pushed a commit
that referenced
this pull request
Aug 9, 2023
) * Fix cli verbs ignoring the passed modName. Fix NxmDownloadProtocolHandler ignoring passed modName. # Conflicts: # src/NexusMods.CLI/Verbs/DownloadAndInstallMod.cs * Add final check for ModManagementVerb tests * Make AVerbTest public so it can be used in other tests * Add SkyrimLegendary edition end to end tests for milestone 1. - Installs SKSE, Skyui, USLEP and check if everything went well. * Add milestone one tests for SkrimSpecialEdition - Install SKSE64, Skyui, USSEP and check if everything went well - Some code formatting * Fix build * Use const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #425
Fixes #517
Added fixes for verbs not setting modName correctly, small improvement to another test and some formatting.