Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try and fix flakey tests #511

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Try and fix flakey tests #511

merged 1 commit into from
Aug 8, 2023

Conversation

halgari
Copy link
Collaborator

@halgari halgari commented Aug 3, 2023

Two fixes

  • Flush .ZIP files before returning from a test function, this might help with cases were we get ".zip is not an archive"
  • Move the number of socket retries from 4 -> 16, because the network for the test runners on GH seem super flakey at times
@halgari halgari requested a review from a team August 3, 2023 13:22
Sewer56
Sewer56 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@halgari halgari merged commit 90c0700 into main Aug 8, 2023
1 of 3 checks passed
@halgari halgari deleted the fix-flakey-tests branch August 8, 2023 16:53
halgari added a commit that referenced this pull request Aug 9, 2023
@halgari
Increase the number of network retries to try and prevent test failur…
ceba510 
…es (#511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@halgari @Sewer56 @erri120