Settings improvements #1618
Merged
Settings improvements #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
erri120
commented
Jun 13, 2024
•
erri120
commented
- Added sections, resolves Add settings sections #1370.
- Assigned settings to sections, resolves Assign sections to settings #1571.
- Re-worded and re-organized settings (also closes Telemetry/User data text changes - multiple locations #1606).
- Can now add links to settings, added one to link to the Privacy site.
Al12rs
approved these changes
Jun 13, 2024
| .WithDescription("Send anonymous analytics information and usage data to Nexus Mods.") | ||
| .AddToSection(Sections.Privacy) | ||
| .WithDisplayName("Send usage data") | ||
| .WithDescription("Help us improve the App by sending usage data to Nexus Mods.") |
Comment on lines
+16
to
+24
| .AddToSection(Sections.Advanced) | ||
| .WithDisplayName("Show game files") | ||
| .WithDescription("Show game files as a mod alongside your added mods.") | ||
| .UseBooleanContainer() | ||
| ) | ||
| .AddPropertyToUI(x => x.ShowOverride, propertyBuilder => propertyBuilder | ||
| .AddToSection(sectionId) | ||
| .WithDisplayName("Show Override") | ||
| .WithDescription("Shows Override in the Mods page.") | ||
| .AddToSection(Sections.Advanced) | ||
| .WithDisplayName("Show Override mod") | ||
| .WithDescription("Shows the Override mod, which contains files generated or modified during gameplay that aren't part of any specific mod.") |
| .WithDescription("When enabled, logs will be written to the console as well as the log file.") | ||
| .AddToSection(Sections.DeveloperTools) | ||
| .WithDisplayName("Log to console") | ||
| .WithDescription("Enables the ConsoleTarget (stdout) for all loggers.") |
Comment on lines
+26
to
+27
| view => view.ViewModel!.SettingEntries, | ||
| view => view.ViewModel!.Sections |
There was a problem hiding this comment.
These are not expected to change right? This should not get triggered on every setting value change for example, right?
| { | ||
| Id = Sections.General, | ||
| IconFunc = static () => IconValues.Desktop, | ||
| Name = "General", |
| .WithDescription("For testing the Xbox Game Pass detection") | ||
| .AddToSection(Sections.Experimental) | ||
| .WithDisplayName("Enable Xbox Game Pass support") | ||
| .WithDescription("Allows you to manage games installed with Xbox Game Pass.") |
|
Here tests are failing |
Al12rs
approved these changes
Jun 13, 2024
|
Wow, this looks really good! (haven't looked at the code, but the screenshots look awesome. |
|
This is my bad but when we changed the diagnostics section to "Privacy", I should have also updated the icon. |
|
"Minimum severity" diagnostic setting needs updated text.
|
Al12rs
requested changes
Jun 17, 2024
src/Abstractions/NexusMods.Abstractions.Games.Diagnostics/DiagnosticSettings.cs
Outdated
Show resolved
Hide resolved
…nosticSettings.cs Co-authored-by: Al <26797547+Al12rs@users.noreply.github.com>
Al12rs
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
@captainsandypants reviewed in call with me and this should be good to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.