Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide download speed graph line after 5 ticks #1597

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Hide download speed graph line after 5 ticks #1597

merged 4 commits into from
Jun 13, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Jun 12, 2024 •
edited
Loading

As requested by @captainsandypants.
@erri120 erri120 requested a review from Al12rs June 12, 2024 10:51
@erri120 erri120 self-assigned this Jun 12, 2024
Al12rs
Al12rs requested changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@Al12rs Al12rs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you open the page with no dls, line is visible for 5 seconds
src/NexusMods.App.UI/Pages/Downloads/InProgressViewModel.cs Outdated Show resolved Hide resolved
@erri120 erri120 requested a review from Al12rs June 12, 2024 12:06
@erri120 erri120 requested a review from Al12rs June 12, 2024 13:44
@Al12rs
Copy link
Contributor

Al12rs commented Jun 13, 2024

This is consistently stalling every time, should check tests locally before proceeding
@erri120 erri120 merged commit 093fd9e into Nexus-Mods:main Jun 13, 2024
5 of 6 checks passed
@erri120 erri120 deleted the download-graph-improvements branch June 13, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@erri120 @Al12rs