ToolTip Styling and Designer preview fix #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found the issue for tooltip styling not applying. I have to fix the tooltip position now though.. |
erri120
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the designer preview, we were not calling
Host.StartAsync(), which caused exceptions in the designer related to DB not being initialized.After adding
Host.StartAsync()though, I also excluded SingleProcess (CLIServer and CLIClient) from being added to the Designer Service collection, to avoid the designer claiming single process lock.For ToolTip styling, I added the Styles as defined on figma and fixed the SpineDownloadButton and IconButton Styles from bleeding into the ToolTips.
The ToolTip BoxShadow seems to work only in some cases though, there might be a problem with the outer padding value not being respected for some reason. The main issue was that
ClipToBounds=Falsedidn't work onToolTipcontrol itself, so I had to add the padding.