Restyle of ToggleSwitch #1549
Merged
Restyle of ToggleSwitch #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al12rs
reviewed
Jun 5, 2024
...rols/Settings/SettingEntries/SettingInteractionControls/Toggle/SettingToggleControl.axaml.cs
Outdated
Show resolved
Hide resolved
Al12rs
reviewed
Jun 5, 2024
...ontrols/Settings/SettingEntries/SettingInteractionControls/Toggle/SettingToggleControl.axaml
Outdated
Show resolved
Hide resolved
Al12rs
reviewed
Jun 5, 2024
...hemes/NexusMods.Themes.NexusFluentDark/Styles/Controls/ToggleSwitch/ToggleSwitchStyles.axaml
Outdated
Show resolved
Hide resolved
Al12rs
reviewed
Jun 5, 2024
|
Removed one of the ClipToBounds now it was set in the style |
Al12rs
reviewed
Jun 6, 2024
There was a problem hiding this comment.
See comment above for moving ClipToBounds to xaml.
Btw I tested this and it's glorious.
One thing that I can think we might want in the future would be adding transition speeds, to simulate an animation when switching the states, but we can see about that later.
Al12rs
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restyled ToggleSwitch to match Figma. Added the smaller variation by creating a
Compactclass. Updated the two places that the control is used to use this new class. Needed to set ClipToBounds=False in a couple of places to accommodate the new hover state.Fixes #1550