Added: Requested Mod Library Refinements #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Involved wrangling with Avalonia styling as usual, and then noticing I was silly
Need to patch SuggestedName so it shows in the view
Al12rs
requested changes
Jun 6, 2024
src/NexusMods.App.UI/Pages/ModLibrary/FileOrigins/FileOriginEntry/FileOriginEntryViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Pages/ModLibrary/FileOrigins/FileOriginEntry/FileOriginEntryViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Pages/ModLibrary/FileOrigins/FileOriginsPageViewModel.cs
Outdated
Show resolved
Hide resolved
|
This PR conflicts with |
Sewer56
force-pushed
the
mod-library-refinement-v2
branch
from
4bbcc43
to
11f2159
Compare
|
This PR doesn't conflict with |
|
This PR conflicts with |
|
This PR doesn't conflict with |
erri120
reviewed
Jun 10, 2024
src/NexusMods.App.UI/Pages/ModLibrary/FileOrigins/FileOriginsPageViewModel.cs
Outdated
Show resolved
Hide resolved
erri120
approved these changes
Jun 11, 2024
Al12rs
approved these changes
Jun 11, 2024
|
Plz wait to merge, I want to run the code locally to check a couple of things |
|
All good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves registering and adding a mod to the
Mod Libraryview.This also accounts for edge cases, such as
Mod Libraryupdating when you perform actions on another panel.For now installing follows the behaviour that a mod can be ran via Advanced Installer at any time. However, a regular installer may not install a mod twice (the button will be disabled). The design for that is not set in stone (currently undefined). We may change it depending on feedback. For now, I double checked and confirmed with @captainsandypants who said that the current behaviour in the PR is ok.
Misc Note:
I need to figure out if I can get Rider to output src/NexusMods.App.UI/Resources/Language.Designer.cs in the same format as VS. Because that huge diff is unnecessary. I have to reboot to Windows every time I add some strings.