Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: App Uninstallation in Single File Apps & Improve PupNet CI Build Step #1503

Merged
merged 2 commits into from
May 30, 2024
Merged

Fixed: App Uninstallation in Single File Apps & Improve PupNet CI Build Step #1503

merged 2 commits into from
May 30, 2024

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented May 30, 2024

This is a simple two set of patches:

  • Replacing Assembly.GetExecutingAssembly().Location
    • Single-File Apps don't have an assembly location. (Breaking change)
    • So we use the folder used for resolving assemblies instead.
  • Ensuring CI uses our locally built PupNet
    • Depending on how NuGet is configured on Actions runner, there's a technical possibility it could install a release from nuget.org.
    • So to avoid this, we build and install a custom version.

You can find a test CI Run at https://github.com/Sewer56/NexusMods.App/actions/runs/9302098600 . Binary from that CI run is also on Slack.
@Sewer56
Bugfix: Assembly.GetExecutingAssembly().Location had a breaking chang…
397532d 
…e for Single File Apps, so we'll use folder that's used to probe for assemblies
@Sewer56
Changed: Build PupNet Properly
2f74cbe
@Sewer56 Sewer56 added the Bug Something isn't working label May 30, 2024
@Sewer56 Sewer56 requested a review from a team May 30, 2024 12:25
@Sewer56 Sewer56 self-assigned this May 30, 2024
@Sewer56 Sewer56 merged commit 7b6a8fb into release_v0.5 May 30, 2024
@Sewer56 Sewer56 deleted the release_0.5_no_miku branch May 30, 2024 12:32
Sewer56 added a commit to Sewer56/NexusMods.App that referenced this pull request May 30, 2024
@Sewer56
Merge pull request Nexus-Mods#1503 from Nexus-Mods/release_0.5_no_miku
eb5005e 
Fixed: App Uninstallation in Single File Apps & Improve PupNet CI Build Step
This was referenced May 30, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
2 participants
@Sewer56 @Al12rs