Cleanup: Toolbars in App no longer include unused nesting. #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al12rs
requested changes
May 30, 2024
src/NexusMods.App.UI/Pages/ModLibrary/FileOrigins/FileOriginsPageView.axaml
Outdated
Show resolved
Hide resolved
Al12rs
approved these changes
May 30, 2024
|
Closing and reopening to rebase CI tests onto latest main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly improves how we present toolbars in the various user interface elements.
Previously, inner contents of every single toolbar was declared as something like:
(Note: Some views had
Orientation == Horizontaland some hadAlignment == Right, both are redundant with our styles)The first column of the Grid being reserved to represent the title.
However, none of our current views actually have a title on the toolbar, therefore this can be simplified to:
<StackPanel>Greatly reducing nesting, and making UI work easier.
When I was working with moving some of the buttons over from My Mods to Mod Library, I noticed this, and thus have cleaned up this unneeded nesting.