Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the Console on Windows by Default #1410

Merged
merged 1 commit into from
May 23, 2024
Merged

Disable the Console on Windows by Default #1410

merged 1 commit into from
May 23, 2024

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented May 22, 2024 •
edited by erri120
Loading

Fixes #1368.
@Sewer56 Sewer56 mentioned this pull request May 22, 2024
Closed
@Sewer56
Copy link
Member Author

Sewer56 commented May 22, 2024

fixes #1368
@Sewer56 Sewer56 requested a review from a team May 22, 2024 12:35
@Sewer56 Sewer56 self-assigned this May 22, 2024
@Sewer56 Sewer56 added the Design UI/UX This is related to the UI. label May 22, 2024
@erri120
Copy link
Member

erri120 commented May 22, 2024

@Al12rs or @halgari should test this on Windows.
@Sewer56
Copy link
Member Author

Sewer56 commented May 22, 2024

(I tested this on Windows too btw)

Anyway, you'll still get logs in IDE as usual, just not in console.
@Al12rs
Copy link
Contributor

Al12rs commented May 22, 2024 •
edited
Loading

@Al12rs or @halgari should test this on Windows.

Can confirm, console logs show up fine if you start the app from a console or from IDE. If you start app normally from explorer no console window is created.
@erri120 erri120 merged commit 849e027 into main May 23, 2024
3 of 6 checks passed
@erri120 erri120 deleted the disable-console-by-default branch May 23, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design UI/UX This is related to the UI.
3 participants
@Sewer56 @erri120 @Al12rs