Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completed downloads section on Downloads page #1397

Merged
merged 30 commits into from
May 22, 2024
Merged

Completed downloads section on Downloads page #1397

merged 30 commits into from
May 22, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented May 21, 2024

Breakdown:

  • Columns:
    • Mod Name
    • Version
    • Game
    • Size
    • Completed DateTime
    • Actions:
      • View in library
      • Clear (hide)
  • ToolBar:
    • Clear button
      • CanExecute
    • Clear completed button
      • CanExecute
    • Fix Cancel button being enabled even with no selection
  • Functionality:
    • Filter out hidden downloads
    • Clear selected
      • CanExecute
    • Clear all
      • CanExecute
    • Only show Completed section if there are completed downloads
    • View in library
    • Counter of completed downloads
  • Backend data:
    • Completed DateTime
    • Hidden status
    • Humanized size
    • Humanized Date
  • Bindings
  • Use template rows to be able to set text styling
  • Don't use active AutoRefresh
  • Move all ICommands to ReactiveCommands
  • Fix bad async usages for existing methods
  • Translations
  • UI layout
    • Put in scroller
    • Fix layout

Skipped:

  • Add collapsible sections (Expander needs to be restyled to match designs, which would have taken time)

image
Al12rs added 25 commits May 20, 2024 11:17
@Al12rs
Add basic UI for completed section
fc85df9
@Al12rs
Add basic viewmodel data for Completed section
382126a
@Al12rs
Add columns layout
8242ed5
@Al12rs
Fix grid not showing
0fcd09c
@Al12rs
Add humanized size
06c07b4
@Al12rs
Add CompletedAt and Hidden database fields
1be1bfd
@Al12rs
Wire up and update completed download time data
e61924c
@Al12rs
WIP:
8ed69ea 
- Bindings for all columns and commands
- Is Hidden filter and commands
@Al12rs
Use Hidden status instead of custom attribute, otherwise tasks don't …
a95dda6 
…get update when the status changes
@Al12rs
Revert "Use Hidden status instead of custom attribute, otherwise task…
3550190 
…s don't get update when the status changes"

This reverts commit a95dda6.
@Al12rs
WIP: Use IsHidden VM property to listen for updates.
d801522
@Al12rs
Implement SetHidden functionality
74e2ad9
@Al12rs
Remove redundant AtuoRefresh, this should no longer be needed with th…
0ba2dc4 
…e new DB changes that already refresh the changeset based on status
@Al12rs
Add scrollviewer and fix layout after removing expander
5a6c415
@Al12rs
Fix missing cancelled status discriminator
d2ccc29
@Al12rs
Fix Text styling by and fix column sizes not working right
9314aad
@Al12rs
Fix layout margins and paddings
99eb9b2
@Al12rs
Refresh selection observables based on status changes
f935358
@Al12rs
Clear and Clear Completed buttons functionality and CanExecute
5a51d9d
@Al12rs
Add completed downloads count and auto fix width
7b0794a
@Al12rs
View In Library functionality
45d8424
@Al12rs
Hide Completed downloads sections if it is empty
ef40715
@Al12rs
Move all commands to ReactiveCommands
69e88b7
@Al12rs
Translations
8344bfd
@Al12rs
Use proper async methods for async functionality
7ffbc28
@Al12rs Al12rs requested a review from a team May 21, 2024 14:26
@Al12rs Al12rs self-assigned this May 21, 2024
@erri120 erri120 self-requested a review May 21, 2024 14:33
@Patriot99 Patriot99 mentioned this pull request May 21, 2024
Merged
erri120
erri120 requested changes May 22, 2024
View reviewed changes
Copy link
Member

@erri120 erri120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd definitely wanna rework the downloads page completely in the near future. That thing is a horrifying mess of tech debt. For now, just check the comments I wrote.
src/Networking/NexusMods.Networking.Downloaders/Tasks/State/CompletedDownloadState.cs Show resolved Hide resolved
src/Networking/NexusMods.Networking.Downloaders/Tasks/ADownloadTask.cs Outdated Show resolved Hide resolved
src/Networking/NexusMods.Networking.Downloaders/DownloadService.cs Outdated Show resolved Hide resolved
src/Networking/NexusMods.Networking.Downloaders/DownloadService.cs Outdated Show resolved Hide resolved
src/NexusMods.App.UI/Pages/Downloads/IInProgressViewModel.cs Outdated Show resolved Hide resolved
src/NexusMods.App.UI/Pages/Downloads/InProgressView.axaml.cs Outdated Show resolved Hide resolved
src/NexusMods.App.UI/Pages/Downloads/InProgressView.axaml.cs Show resolved Hide resolved
src/NexusMods.App.UI/Pages/Downloads/InProgressViewModel.cs Show resolved Hide resolved
src/NexusMods.App.UI/Pages/Downloads/InProgressViewModel.cs Show resolved Hide resolved
src/NexusMods.App.UI/Pages/Downloads/InProgressViewModel.cs Show resolved Hide resolved
@Al12rs Al12rs requested a review from erri120 May 22, 2024 09:44
@Al12rs Al12rs merged commit 3742d53 into main May 22, 2024
6 checks passed
@Al12rs Al12rs deleted the feat/888-completed-downloads branch May 22, 2024 10:52
@erri120 erri120 mentioned this pull request May 22, 2024
Closed
@Al12rs Al12rs mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Al12rs @erri120