Add warning modal dialog

[erri120]

Resolves #1376.

[Sewer56]

I think we may have a bug that affects this PR.
Either that, or we're missing something.

If I recall correctly, Community and Design (@Pickysaurus @captainsandypants) wanted for the dialog to show on every boot. And later down the road in 'Beta' we'd add a don't show again option.

That is actually the case right now, but I'm not sure if that's happening for the right reason.

In AlphaWarningViewModel.MaybeShow we try to obtain a previous instance of AlphaSettings from MnemonicDB, that is _settingsManager.Get<AlphaSettings>(). On my machine (with fresh DataModel), this seems to always return an AlphaSettings where HasShownModal is false. Even though in the previous run of the App we've set that to true.

Switching to the JSON backend seems to correct this behaviour.

public static ISettingsBuilder Configure(ISettingsBuilder settingsBuilder)
{
    return settingsBuilder
        .ConfigureStorageBackend<AlphaSettings>(builder => builder.UseJson());
}

In which case the dialog is not shown again (we get HasShownModal == true on subsequent boot).
Can you doublecheck that what I'm experiencing here is a bug with the MMDB settings backend?

[Sewer56]

Oh and @captainsandypants ; currently the Show Changelog button will show the changelog under the current modal. If you have a design or desired behaviour for that stated anywhere, do let us know. Right now you won't really know it opened until you dismiss the modal.

[Sewer56]

Technically speaking these should be localized, given we will likely reuse this dialog for beta; which may have non-English people trying to participate, but it's not big enough a deal to block the PR. Am just commenting as it's worth pointing out.

[erri120]

@Sewer56 can you explain your comment, I'm not sure I follow. The overlay will only appear once, similar to the telemetry dialog.

[erri120]

And I just realized I forgot to hook up the help icon.

[Sewer56]

@Sewer56 can you explain your comment, I'm not sure I follow. The overlay will only appear once, similar to the telemetry dialog.

The tl;dr is I reset my DataStore to get to a clean state and

• Saving AlphaSettings with MnemonicDB backend did not work.
• Saving AlphaSettings with JSON backend worked.

I was asking if this behaviour is only something that reproduces on my machine.

[erri120]

@Sewer56 can you explain your comment, I'm not sure I follow. The overlay will only appear once, similar to the telemetry dialog.

The tl;dr is I reset my DataStore to get to a clean state and

* Saving AlphaSettings with MnemonicDB backend did not work.

* Saving AlphaSettings with JSON backend worked.

I was asking if this behaviour is only something that reproduces on my machine.

Sounds like a you problem 😅.

[Sewer56]

Goddamn it 😅

[Sewer56]

Ah, a full rebuild fixed it. Very strange.
In any case, do confirm with design if that's what they want.
I do think they wanted it to show on every boot till beta. Unless we've decided to go through with showing it once per version.

[erri120]

Ah, a full rebuild fixed it. Very strange. In any case, do confirm with design if that's what they want. I do think they wanted it to show on every boot till beta. Unless we've decided to go through with showing it once per version.

From figma: