Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Ability to Uninstall the App #1383

Merged
merged 26 commits into from
May 21, 2024
Merged

Added: Ability to Uninstall the App #1383

merged 26 commits into from
May 21, 2024

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented May 20, 2024

This PR migrates the remaining code related to removing loadouts and app uninstallation.

  • ✅ Uninstall script runs on Windows.
  • ✅ Uninstalling with App Running on Windows (files in use) runs as intended.
    • On Windows, it kills all app instances and performs a manual cleanup via dynamically generated powershell script.
    • The powershell code written should be trivial enough that even 15+ year old versions of it should run it fine.
  • ✅ Adds missing install and uninstall icon.
  • ✅ Uninstalling deletes whole DataModel directory and...
    • Configured Logging Location
    • MnemonicDB Path
    • File Extractor Temp Folder
    • Logger base folder
    • Default Config folder for JSON Settings Storage backend
    • All archive locations where user has decided to store .nx archives.

I've tried to be comprehensive with the locations deleted, removing our defaults as well as any paths that are configurable. (Even if they are not yet exposed via the Settings UI!!). After deletion, no files of notable size should hopefully be left over on disk.

Note(s)

  • Still need to wait for upstream https://github.com/kuiperzone/PupNet-Deploy/pull/36 to merge the necessary changes to PupNet.

fixes #377
fixes #1161
fixes #1200

@Sewer56 Sewer56 added the Tech: data-store This is related to the Data Store. label May 20, 2024
@Sewer56 Sewer56 requested a review from a team May 20, 2024 18:54
@Sewer56 Sewer56 self-assigned this May 20, 2024
@Sewer56
Copy link
Member Author

Sewer56 commented May 20, 2024

Oh, and of course.

fixes #377
fixes #1161
fixes #1200

@erri120 erri120 self-requested a review May 20, 2024 19:23
src/NexusMods.App/Commandline/CleanupVerbs.cs Outdated Show resolved Hide resolved
src/NexusMods.App/Commandline/CleanupVerbs.cs Outdated Show resolved Hide resolved
@Sewer56 Sewer56 merged commit 3dfcbf1 into main May 21, 2024
6 of 7 checks passed
@erri120 erri120 deleted the uninstall-app-mmdb branch May 29, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech: data-store This is related to the Data Store.
3 participants