Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish Mod Library #1347

Merged
merged 11 commits into from
May 15, 2024
Merged

Finish Mod Library #1347

merged 11 commits into from
May 15, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented May 14, 2024 •
edited
Loading

This implements the remaining missing features of the Mod Library as current designs.

Summary:

  • Filter entries by Game, if entry has no Game, it is shown.
  • Compute and show "Downloaded" DateTime column which is either when a manual archive was first analyzed, or when a download was started.
  • Show Version data if available (it is only present on NXM downloads)
  • Compute and update "Added" DateTime column by querying the loadout mods for matches and getting the most recent CreatedAt time
  • Excluded Nested archives (e.g. SMAPI internal archive) from showing up
  • Used Nexus Mod page name if available instead of file name

I'm not completely happy with the subscriptions and the all the attributes shenanigans, but at least everything seems to work now.

image
@Al12rs Al12rs mentioned this pull request May 14, 2024
Closed
8 tasks
@Al12rs Al12rs self-assigned this May 14, 2024
@Al12rs Al12rs requested a review from a team May 14, 2024 13:21
@erri120 erri120 self-requested a review May 14, 2024 13:33
erri120
erri120 requested changes May 14, 2024
View reviewed changes
src/Abstractions/NexusMods.Abstractions.FileStore/TypeFinder.cs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire file can probably be removed as it's not used anymore. @halgari.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without adding this it wouldn't work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, weird.
src/Abstractions/NexusMods.Abstractions.FileStore/Downloads/DownloadAnalysis.cs Outdated Show resolved Hide resolved
src/NexusMods.DataModel/FileOriginRegistry.cs Outdated Show resolved Hide resolved
src/NexusMods.App.UI/Pages/ModLibrary/FileOrigins/IFileOriginsPageViewModel.cs Outdated Show resolved Hide resolved
src/NexusMods.App.UI/Pages/ModLibrary/FileOrigins/FileOriginsPageViewModel.cs Outdated Show resolved Hide resolved
src/NexusMods.App.UI/Pages/ModLibrary/FileOrigins/FileOriginsPageViewModel.cs Show resolved Hide resolved
src/NexusMods.App.UI/Pages/ModLibrary/FileOrigins/FileOriginEntry/FileOriginEntryViewModel.cs Outdated Show resolved Hide resolved
src/NexusMods.App.UI/Pages/ModLibrary/FileOrigins/FileOriginEntry/FileOriginEntryViewModel.cs Outdated Show resolved Hide resolved
src/NexusMods.App.UI/Pages/ModLibrary/FileOrigins/FileOriginEntry/FileOriginEntryViewModel.cs Outdated Show resolved Hide resolved
@Al12rs Al12rs requested a review from erri120 May 14, 2024 18:01
@Al12rs Al12rs merged commit 180e4e8 into main May 15, 2024
7 checks passed
@Al12rs Al12rs deleted the feat/1284-mod-library-refinements branch May 15, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Al12rs @erri120