Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system extractor executable #1308

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented May 6, 2024

Fixes #1306.

Usage:

NEXUSMODS_APP_USE_SYSTEM_EXTRACTOR=1 dotnet build

@erri120 erri120 requested a review from Sewer56 May 6, 2024 09:53
@erri120 erri120 self-assigned this May 6, 2024
@Sewer56
Copy link
Member

Sewer56 commented May 6, 2024

I'll handle this when I'm back to work tomorrow.
Just gotta remember that there's always the fact we also have to patch the code to invoke system 7zz. i.e. just remove path up to 7zz itself.

@erri120
Copy link
Member Author

erri120 commented May 6, 2024

Right, then something like USE_SYSTEM_EXTRACTOR might be more fitting.

@erri120 erri120 changed the title Add NEXUSMODS_APP_NO_BUNDLED_EXTRACTORS condition May 6, 2024
@Sewer56
Copy link
Member

Sewer56 commented May 7, 2024

Looks perfectly reasonable to me.
We could also check AppImage just in case, but I doubt that'd be an issue even if used there.
AppImage users probably won't want this flag as by design the AppImage should ship the deps.

@erri120 erri120 merged commit 0a4108b into Nexus-Mods:main May 7, 2024
2 of 6 checks passed
@erri120 erri120 deleted the fix/1306-7zz-flag branch May 7, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants