Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added: Remove Loadouts & Unmanage Games #1279

Merged
merged 20 commits into from
Apr 30, 2024
Merged

Added: Remove Loadouts & Unmanage Games #1279

merged 20 commits into from
Apr 30, 2024

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Apr 29, 2024 •
edited
Loading

fixes #399

This PR adds the ability to remove loadouts and cleanup after a game.

Important Notes:

  • Removing an Active Loadout will Reset the Game to Its Original Disk State.
  • Unmanaging the game will Reset the Game to its Original Disk State
    • And remove the original state, so a new original state is created next time game is managed.
    • This logic will also trigger on removal of last loadout, not just explicit 'unmanage'.
  • Existing Code was slightly tweaked to handle loadout removal more gracefully.
    • (Previously, UI did not like it)
  • Added a CLI verb for deleting loadout(s).
  • New functionality has accompanying simple tests.
  • Hitting the Trash Can in Current UI Unmanages a Game
    • Intended as a dev tool, until this part of UI is redesigned
  • Updates some previous code to use newer MnemonicDB APIs
@Sewer56
Added: The ability to obliterate (unmanage) a game from the Data Store
234c591
@Sewer56
Added: Apply of original state now is decently fast.
2aae58f 
Everything works aside from external elements not handling deletions now
@Sewer56
Changed: LoadoutRegistry now Returns Null on Invalid Loadout to Match…
f78b507 
… Public API and Prior Written Code
@Sewer56
Fixed: Potential concurrency issues with game nuking and
6995ed1
@Sewer56
Added: Ability to remove an individual loadout.
b29fa49
@Sewer56
Added: Test for Deleting a Loadout
f84aba2
@Sewer56
Fixed: Loadout Creation Test when using Stubbed Synchronizer
379db9a
@Sewer56
Improved: Better scan for whether loadout is active. And remove all l…
5bb3ee1 
…oadout revisions.
@Sewer56
Updated: MneumonicDB
8a59cef
@Sewer56
Merge remote-tracking branch 'erri120/main' into remove-loadout
0c05548
@Sewer56
Merge remote-tracking branch 'origin/main' into remove-loadout
bbf3d17
@Sewer56 Sewer56 self-assigned this Apr 29, 2024
@Sewer56 Sewer56 requested a review from a team April 30, 2024 05:50
@Sewer56 Sewer56 changed the title Added: Removal of Loadouts Apr 30, 2024
@Sewer56 Sewer56 added the Tech: data-store This is related to the Data Store. label Apr 30, 2024
@Sewer56 Sewer56 marked this pull request as ready for review April 30, 2024 05:56
@erri120 erri120 self-requested a review April 30, 2024 07:33
erri120
erri120 requested changes Apr 30, 2024
View reviewed changes
src/NexusMods.App.UI/Pages/MyGames/MyGamesViewModel.cs Outdated Show resolved Hide resolved
src/NexusMods.DataModel/Attributes/DiskState.cs Show resolved Hide resolved
src/NexusMods.DataModel/Loadouts/DiskStateRegistry.cs Outdated Show resolved Hide resolved
src/NexusMods.DataModel/Loadouts/LoadoutRegistry.cs Outdated Show resolved Hide resolved
src/NexusMods.DataModel/Loadouts/LoadoutRegistry.cs Outdated Show resolved Hide resolved
src/Abstractions/NexusMods.Abstractions.Loadouts.Synchronizers/ALoadoutSynchronizer.cs Show resolved Hide resolved
src/Abstractions/NexusMods.Abstractions.Loadouts.Synchronizers/ALoadoutSynchronizer.cs Outdated Show resolved Hide resolved
src/Abstractions/NexusMods.Abstractions.Loadouts.Synchronizers/ALoadoutSynchronizer.cs Outdated Show resolved Hide resolved
src/Abstractions/NexusMods.Abstractions.Loadouts.Synchronizers/ALoadoutSynchronizer.cs Outdated Show resolved Hide resolved
src/Abstractions/NexusMods.Abstractions.Loadouts.Synchronizers/ALoadoutSynchronizer.cs Outdated Show resolved Hide resolved
@Sewer56 Sewer56 merged commit f985160 into main Apr 30, 2024
6 checks passed
@Sewer56 Sewer56 mentioned this pull request May 1, 2024
Merged
@erri120 erri120 deleted the remove-loadout branch May 1, 2024 15:19
@Al12rs Al12rs mentioned this pull request May 8, 2024
Closed
@Sewer56 Sewer56 mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech: data-store This is related to the Data Store.
3 participants
@Sewer56 @erri120 @Al12rs