Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added: Vanilla/Original Game State Reuse #1259

Merged
merged 13 commits into from
Apr 23, 2024
Merged

Added: Vanilla/Original Game State Reuse #1259

merged 13 commits into from
Apr 23, 2024

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Apr 23, 2024 •
edited
Loading

fixes #1197

This PR adds very basic support for storing and reusing DiskStates across game manage operations.

After some familiarizing myself with MnemonicDB, and a prototype or two (in earlier commits); I settled on a very simple solution that will make it easy to clean up afterwards.

DoubleLoadout.mp4

This is OK to review, I drafted it because I'm still adding a test.
@Sewer56 Sewer56 added the Tech: data-store This is related to the Data Store. label Apr 23, 2024
@Sewer56 Sewer56 requested a review from halgari April 23, 2024 21:27
@Sewer56 Sewer56 self-assigned this Apr 23, 2024
@Sewer56 Sewer56 marked this pull request as ready for review April 23, 2024 21:47
halgari
halgari approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@halgari halgari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work here, I wasn't sure about having a separate set of attributes for this, but they really are separate entities and we never want to use them together, so by all means, separate them. :)
@halgari halgari merged commit 3d64fc6 into main Apr 23, 2024
8 of 9 checks passed
@halgari halgari deleted the vanilla-game-state branch April 23, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech: data-store This is related to the Data Store.
2 participants
@Sewer56 @halgari