Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better RunThroughSteam #1206

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Better RunThroughSteam #1206

merged 3 commits into from
Apr 11, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Apr 11, 2024 •
edited
Loading

I don't know if this will fix issue #1151, but it will definitely allow us to debug the issue better.

Changes:

  • IOSInterop.OpenUrl add a fireAndForget parameter. Opening Steam on Linux using xdg-open blocked the entire task until Steam exited. This was undesired, so we can now opt in to a fire-and-forget-style of task running.
  • More logging in RunThroughSteam and WaitForProcessToStart.
  • Increased timeout from 1 minute to 5 minute in case Steam or the game take too long to start.
@erri120
Improve RunThroughSteam
f2e4c08 
- Better logging in `WaitForProcessToStart`.
- A bit more explanation why it does the things it does.
@erri120
Add fireAndForget to OpenUrl
dc98ac4
@erri120
Fire and forget
5db4485
@erri120 erri120 requested a review from a team April 11, 2024 09:49
@erri120 erri120 self-assigned this Apr 11, 2024
@erri120 erri120 mentioned this pull request Apr 11, 2024
Closed
@erri120 erri120 merged commit f5d9d12 into Nexus-Mods:main Apr 11, 2024
5 checks passed
@erri120 erri120 deleted the feat/better-run-through-steam branch April 11, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@erri120 @Al12rs