Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Apply Diff View #1202

Merged
merged 20 commits into from
Apr 10, 2024
Merged

Implement Apply Diff View #1202

merged 20 commits into from
Apr 10, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Apr 10, 2024 •
edited
Loading

image

What was done:

  • Added "View Apply changes" button to access the page
  • Added new ApplyDiffView page
  • Added new DiffTreeViewModel for existing FileTreeView
  • Added a modified "State" column
  • Added colors for modified items
  • Added a Refresh button to recompute the diff
  • Added Files and Size counters in the status bar as per design
  • Auto expanded folders with changes
  • Added loading view while asynchronously computing the tree
  • Moved LoadoutToDiskDiff to ALoadoutSynchronizer from extension method, it wasn't accessible otherwise
  • Added a couple of methods to AGamePathNodeTree: GetRoots() and GetAllDescendentDirectories() that were needed for creating the viewmodel tree
  • Implemented PR feedback from Apply diff backend #1172

What could be added:

  • Checkbox or option to only show changes (exclude all unmodified files)
    I feel this view would really benefit from this addition.
Al12rs added 18 commits April 8, 2024 11:16
@Al12rs
WIP: Add skeletons for Apply diff page
28352aa
@Al12rs
WIP: moved things around and added initial implementation for DiffTreeVM
10ba8bc
@Al12rs
WIP PR feedback and fixes
93ebdda
@Al12rs
Implement opening the diff page from ui and fix a bunch of issues
b87fdf8
@Al12rs
Add refresh button functionality and fix deserializing the context
0d3772f
@Al12rs
Add root directories (inefficient version)
78bda08
@Al12rs
WIP: add colors and strikethrough to view but no one is using them
25d8c6f
@Al12rs
Pass the change type to the filetree node and change Modified color t…
5b39164 
…o Info
@Al12rs
Add change state column to diff tree view
4907147
@Al12rs
Optimize adding directories sizes and file counts to the tree
0a171f5
@Al12rs
- Add status bar values
d9fda7c 
- Increase state column size
- Set tab title
- Translations
@Al12rs
Auto expand folders that have modifid states
c0c94f3
@Al12rs
Fix counters not resetting on refresh
5be0a64
@Al12rs
Execute refresh asynchronously
04adcbe
@Al12rs
Add design vm
6f24d3b
@Al12rs
Ensure changes happen on UI
fc5e866
@Al12rs
Remove unused property
373672c
@Al12rs
Only show View Apply changes button when there are changes to apply
09ac990
@Al12rs Al12rs requested a review from erri120 April 10, 2024 14:04
@Al12rs Al12rs self-assigned this Apr 10, 2024
@Al12rs Al12rs requested a review from erri120 April 10, 2024 14:53
@Al12rs Al12rs merged commit 439f070 into main Apr 10, 2024
7 checks passed
@Al12rs Al12rs deleted the Apply_diff_ui branch April 10, 2024 15:09
@Al12rs Al12rs mentioned this pull request Apr 11, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Al12rs @erri120