Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More SMAPI diagnostics #1171

Merged
merged 9 commits into from
Apr 8, 2024
Merged

More SMAPI diagnostics #1171

merged 9 commits into from
Apr 8, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Apr 4, 2024 •
edited
Loading

Resolves #1168.

Adds three new diagnostics:

  • Critical: Current game version is lower than the minimum supported version by SMAPI
  • Critical: Current game version is newer than the maximum supported version by SMAPI
  • Suggestion: SMAPI and no SMAPI mods are installed, you should install SMAPI to get started with modding Stardew Valley

2024-04-04_13-58-17
2024-04-04_14-39-30
2024-04-04_14-54-19
@erri120 erri120 requested a review from a team April 4, 2024 12:56
@erri120 erri120 self-assigned this Apr 4, 2024
@Al12rs Al12rs self-requested a review April 4, 2024 14:39
@erri120 erri120 requested a review from Al12rs April 8, 2024 10:53
@erri120
Copy link
Member Author

erri120 commented Apr 8, 2024

I don't really like how versions are handled. The current solution should be fine for now, but I might revisit this later and use ISemanticVersion of SMAPI.
@Al12rs
Copy link
Contributor

Al12rs commented Apr 8, 2024 •
edited
Loading

I didn't try running the app with the latest version, but the code should work in theory. I assume you already tested
@erri120 erri120 merged commit 1e3e0a9 into Nexus-Mods:main Apr 8, 2024
6 checks passed
@erri120 erri120 deleted the feat/issue-1168-smapi-game-version branch April 8, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@erri120 @Al12rs