Update logging #1167
Merged
Update logging #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1167 +/- ##
==========================================
- Coverage 53.10% 52.50% -0.60%
==========================================
Files 674 674
Lines 23120 23185 +65
Branches 1762 1770 +8
==========================================
- Hits 12278 12174 -104
- Misses 10441 10607 +166
- Partials 401 404 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Al12rs
reviewed
Apr 3, 2024
Al12rs
approved these changes
Apr 3, 2024
halgari
reviewed
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nexusmods.app.mainfor the main process onlynexusmods.app.slimfor the "slim" process onlyHaving two logging files fixes the issue where both the main and slim process try to write to the same file. While we didn't have any corruptions of log files, we did have an issue where a slim process will move the current main log to an archive log while the main process would continue writing to the archive log. It made debugging and viewing logs difficult, this PR fixes that issue by clearly separating the two logs.