Add Ingest button #1131
Merged
Add Ingest button #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR conflicts with |
|
Ugh, translation conflicts |
# Conflicts: # src/NexusMods.App.UI/Resources/Language.Designer.cs # src/NexusMods.App.UI/Resources/Language.resx
|
This PR doesn't conflict with |
erri120
requested changes
Mar 26, 2024
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1131 +/- ##
==========================================
- Coverage 53.28% 53.20% -0.09%
==========================================
Files 678 678
Lines 22628 22663 +35
Branches 1725 1725
==========================================
Hits 12057 12057
- Misses 10176 10211 +35
Partials 395 395
Flags with carried forward coverage won't be shown. Click here to find out more.
|
erri120
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1127
This adds a button to ingest outside changes as a temporary stopgap solution to expose the functionality to users, while we figure out how Apply/Ingest should work.
Button is shown regardless of whether there are changes or not (no detection or check)This pretty bad as features go, but anything more would still be temporary anyways until the Apply/Ingest workflow is fully thought out.