Diagnostics for incompatible SMAPI mods #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
==========================================
- Coverage 53.52% 52.47% -1.06%
==========================================
Files 676 678 +2
Lines 22525 22735 +210
Branches 1726 1743 +17
==========================================
- Hits 12057 11930 -127
- Misses 10073 10406 +333
- Partials 395 399 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Al12rs
reviewed
Mar 26, 2024
Comment on lines
-34
to
-40
| /// <summary> | ||
| /// Creates a new instance of <see cref="SMAPIModInstaller"/>. | ||
| /// </summary> | ||
| /// <param name="serviceProvider"></param> | ||
| /// <returns></returns> | ||
| public static SMAPIModInstaller Create(IServiceProvider serviceProvider) => new(serviceProvider); | ||
|
|
There was a problem hiding this comment.
It was used, but it's a weird pattern, so I removed it. The installer is now registered in DI.
Al12rs
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1119.
This PR adds two new diagnostics for Stardew Valley:
The data for these diagnostics are sourced from the internal "mod database" file located at
smapi-internal/metadata.json. SMAPI itself reads this file at startup to issue warnings and errors, we mirror this behavior in the App with diagnostics.Other changes:
3.18.6to4.0.2.DiagnosticManagermore robust when one emitter throws an exception.