Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include disabled SMAPI mods when counting #1122

Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Mar 25, 2024

Fxies #1116.

@erri120 erri120 requested a review from a team March 25, 2024 10:38
@erri120 erri120 self-assigned this Mar 25, 2024
@erri120 erri120 added this to the v0.4 milestone Mar 25, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 53.75%. Comparing base (bdcc9ac) to head (6abfc7c).
Report is 8 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
- Coverage   53.75%   53.75%   -0.01%     
==========================================
  Files         674      674              
  Lines       22431    22433       +2     
  Branches     1723     1723              
==========================================
  Hits        12058    12058              
- Misses       9978     9980       +2     
  Partials      395      395              
Flag Coverage Δ
Linux 53.11% <0.00%> (-0.01%) ⬇️
Windows 52.99% <0.00%> (-0.02%) ⬇️
clean_environment_tests 53.74% <0.00%> (-0.01%) ⬇️
macOS 52.56% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ames.StardewValley/Emitters/MissingSMAPIEmitter.cs 0.00% <0.00%> (ø)
@erri120 erri120 merged commit 38bb865 into Nexus-Mods:main Mar 25, 2024
5 checks passed
@erri120 erri120 deleted the fix/1116-diabled-mod-requires-smapi branch March 25, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants