Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move FileTreeView out of ModFiles #1117

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Move FileTreeView out of ModFiles #1117

merged 5 commits into from
Mar 25, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Mar 25, 2024

This moves out the tree view from the ModInfo Files view, to make it reusable.
This is for #1113

This removes the Locations section at the top, and always creates root nodes with the full path, this is for consistency (easier to reuse this) and regaining vertical space at the top.

@Al12rs Al12rs self-assigned this Mar 25, 2024
@Al12rs Al12rs requested a review from a team March 25, 2024 09:06
@Sewer56
Copy link
Member

Sewer56 commented Mar 25, 2024

This removes the Location bar from the top of the view.

The view looks like this by default:

20240325_09h58m47s_Nexus_Mods_App

With the root node manually expanded:

20240325_09h50m13s_Nexus_Mods_App


Before this PR:

20240325_09h53m13s_Nexus_Mods_App

I'm happy to merge this, but it needs OK from Design ( @captainsandypants ).
The only other suggestion I have, is auto expanding the root node, if it's the only root.

@Al12rs Al12rs merged commit dcfbea4 into main Mar 25, 2024
6 checks passed
@Al12rs Al12rs deleted the apply_diff branch March 25, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants