Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various diagnostic UI improvements #1115

Merged
merged 7 commits into from
Mar 25, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Mar 21, 2024

Part of #1091.

  • Fixes the horizontal line coloring:

2024-03-21_12-18-48

  • Adds chips with counts and filters
  • Adds text for no diagnostics
  • Adds the summary as a header to the details page:
  • Adds some basic Markdown styling:

2024-03-21_15-27-45

@erri120 erri120 self-assigned this Mar 21, 2024
@erri120 erri120 force-pushed the fix/1091-diagnostic-ui-improvements branch from 2b5d870 to b741038 Compare March 21, 2024 13:05
@erri120 erri120 mentioned this pull request Mar 21, 2024
14 tasks
@erri120 erri120 marked this pull request as ready for review March 21, 2024 13:35
@erri120 erri120 requested a review from a team March 21, 2024 13:35
@erri120 erri120 added this to the v0.4 milestone Mar 21, 2024
@Al12rs
Copy link
Contributor

Al12rs commented Mar 21, 2024

Could you add a "No Entries" text if there are no diagnostics to see in a given filtered view?
Use a Subdued foreground color and pick a text style

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 84 lines in your changes are missing coverage. Please review.

Project coverage is 53.18%. Comparing base (ab1c879) to head (f95d363).
Report is 7 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1115      +/-   ##
==========================================
- Coverage   53.97%   53.18%   -0.80%     
==========================================
  Files         673      674       +1     
  Lines       22349    22431      +82     
  Branches     1716     1723       +7     
==========================================
- Hits        12063    11929     -134     
- Misses       9894    10102     +208     
- Partials      392      400       +8     
Flag Coverage Δ
Linux 53.10% <0.00%> (-0.21%) ⬇️
Windows ?
clean_environment_tests 53.17% <0.00%> (-0.79%) ⬇️
macOS 52.52% <0.00%> (-0.25%) ⬇️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...I/Controls/Diagnostics/DiagnosticEntryViewModel.cs 0.00% <0.00%> (ø)
.../Diagnostics/Details/DiagnosticDetailsViewModel.cs 0.00% <0.00%> (ø)
...c/NexusMods.App.UI/Extensions/ClassesExtensions.cs 0.00% <0.00%> (ø)
...rc/NexusMods.App.UI/Resources/Language.Designer.cs 48.56% <0.00%> (-2.19%) ⬇️
.../Pages/Diagnostics/List/DiagnosticListViewModel.cs 0.00% <0.00%> (ø)

... and 31 files with indirect coverage changes

@Al12rs
Copy link
Contributor

Al12rs commented Mar 21, 2024

Did you figure out the chip behavior with Design?

@erri120
Copy link
Member Author

erri120 commented Mar 25, 2024

Did you figure out the chip behavior with Design?

Yeah, they now work similar to tabs, meaning you can only have one filter active at a time.

@erri120 erri120 requested a review from Al12rs March 25, 2024 10:01
@erri120 erri120 merged commit 3b1e579 into Nexus-Mods:main Mar 25, 2024
6 checks passed
@erri120 erri120 deleted the fix/1091-diagnostic-ui-improvements branch March 25, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants