Show diagnostic count #1114
Merged
Show diagnostic count #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sewer56
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Looks good to me.
Small idea, try using C#12 primary constructors for returning the observable (if you can)
public struct DiagnosticCounts(int NumSuggestions, int NumWarnings, int NumCritical)This may make it easier to work with long term.
Make it readonly/record struct depending on your preference. It's a value type, so it gets copied around, so whatever floats your boat.
Al12rs
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1091.