-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better "cancel download" window in Polish UI #1111
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
- Coverage 53.97% 53.92% -0.06%
==========================================
Files 673 673
Lines 22349 22349
Branches 1716 1716
==========================================
- Hits 12063 12051 -12
- Misses 9894 9904 +10
- Partials 392 394 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Looks good to me. Can you indent the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(see above comment)
Strangely the indent didn't update after the last commit. |
Yes, I see that there is another edition. The previous code I did on a PC and the current one is from a smartphone. You can compare the code more easily if you use a PC. |
I did it specifically to make the UI look better. Check Screenshot 1: Check Screenshot 2: CancelDownloadOverlayView_Description__Download is empty because it is unnecessary, and it acts as a dummy (his job is done by CancelDownloadOverlayView_Description_download_will_be_cancelled). |
Alright, that works for me |
I added a couple of changes to the strings so that the "cancel download" window will always match any situation in the Polish version. I tested two scenarios: Canceling one download and canceling at least two downloads or more at the same time. The UI now looks more professional than the previous one, which looked amateurish and did not match every situation.
One download:
Two or more downloads: