Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better "cancel download" window in Polish UI #1111

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

Patriot99
Copy link
Contributor

I added a couple of changes to the strings so that the "cancel download" window will always match any situation in the Polish version. I tested two scenarios: Canceling one download and canceling at least two downloads or more at the same time. The UI now looks more professional than the previous one, which looked amateurish and did not match every situation.

One download:
Screenshot_20240321-103632~3

Two or more downloads:
Screenshot_20240321-104536~2

@erri120 erri120 requested a review from Sewer56 March 21, 2024 10:33
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.92%. Comparing base (ab1c879) to head (d9339ea).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
- Coverage   53.97%   53.92%   -0.06%     
==========================================
  Files         673      673              
  Lines       22349    22349              
  Branches     1716     1716              
==========================================
- Hits        12063    12051      -12     
- Misses       9894     9904      +10     
- Partials      392      394       +2     
Flag Coverage Δ
Linux 53.31% <ø> (+<0.01%) ⬆️
Windows 53.22% <ø> (-0.01%) ⬇️
clean_environment_tests 53.91% <ø> (-0.05%) ⬇️
macOS 52.72% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@Sewer56
Copy link
Member

Sewer56 commented Mar 21, 2024

Looks good to me.

Can you indent the .resx file by hand so it matches the previous version? For some reason the tool you used here, used a different indent, which would probably be reverted again at some point, making the git log a bit more messy.

Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see above comment)

@Sewer56
Copy link
Member

Sewer56 commented Mar 21, 2024

Strangely the indent didn't update after the last commit.
Want me to fix it up myself?

@Patriot99
Copy link
Contributor Author

Strangely the indent didn't update after the last commit. Want me to fix it up myself?

Yes, I see that there is another edition. The previous code I did on a PC and the current one is from a smartphone. You can compare the code more easily if you use a PC.

@Sewer56
Copy link
Member

Sewer56 commented Mar 21, 2024

image

Accidental edit here. Aside from that, looks good to me.

@Patriot99
Copy link
Contributor Author

image

Accidental edit here. Aside from that, looks good to me.

I did it specifically to make the UI look better.

Check Screenshot 1:
CancelDownloadOverlayView_Description_download_will_be_cancelled will only be used if you cancel one download (the app will then generate the mod name).

Check Screenshot 2:
CancelDownloadOverlayView_Description_downloads will only be used if you cancel two or more downloads (the app will then generate a number depending on the canceled downloads).

CancelDownloadOverlayView_Description__Download is empty because it is unnecessary, and it acts as a dummy (his job is done by CancelDownloadOverlayView_Description_download_will_be_cancelled).

@Sewer56
Copy link
Member

Sewer56 commented Mar 21, 2024

Alright, that works for me

@Sewer56 Sewer56 merged commit aeeb048 into Nexus-Mods:main Mar 21, 2024
6 checks passed
@Patriot99 Patriot99 deleted the patch-1 branch March 21, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants