-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown writer #1102
Markdown writer #1102
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1102 +/- ##
==========================================
- Coverage 54.35% 54.18% -0.17%
==========================================
Files 671 672 +1
Lines 22175 22256 +81
Branches 1708 1709 +1
==========================================
+ Hits 12053 12060 +7
- Misses 9724 9802 +78
+ Partials 398 394 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine. Just extremely minor nitpicks.
Quick Question:
- Is the
Mode
intended to be dynamically mutated?
Usually for code like this, I see a design where you have a writer for a specific 'mode' and then you invoke methods for that. This isn't a request to change the code, just curious more than anything.
src/Abstractions/NexusMods.Abstractions.Games.Diagnostics/Writer/DiagnosticWriterMode.cs
Show resolved
Hide resolved
src/Abstractions/NexusMods.Abstractions.Games.Diagnostics/Writer/DiagnosticWriterState.cs
Outdated
Show resolved
Hide resolved
Nope. |
Part of #327.
Allows value formatters to write either plain text or markdown depending on the state.
This PR doesn't include a markdown renderer.