Temp fix for advanced installer not starting #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sewer56
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Fine.
However (quick reminder) please do make an issue for replacing this code for when we get a proper modal system. This is a hack for a side effect of #972 after all.
Edit:
PS. I forgot to specify, this works fine on Linux. I tested before this PR went up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1094
This is a temporary solution that uses a normal window rather than a Modal dialog for the Advanced installer, so that it can be used again for testing and debugging