Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run git builds on schedule #1100

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Mar 20, 2024

Fixes #1079. Using 17 08,15 * * * as a schedule:

At minute 17 past hour 8 and 15

@erri120 erri120 requested a review from a team March 20, 2024 12:54
@erri120 erri120 self-assigned this Mar 20, 2024
Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming our staff stick closer to the standard 9-5 most of the time, would running a 2nd CRON job just after 17:00 not be more suitable?

Just curious.

@Al12rs
Copy link
Contributor

Al12rs commented Mar 20, 2024

Times seem pretty arbitrary, some comments for why would be good

@erri120
Copy link
Member Author

erri120 commented Mar 20, 2024

UTC (office and @Sewer56) @erri120 and @Al12rs @halgari
08:17 09:17 02:17
15:17 16:17 09:17

I picked the minutes arbitrary, it's considered "good practice" to pick something at random that isn't exactly 0, 15, 30, or 45 because everyone else runs their CI at that time.

I picked the hours 08 and 15 because it's before most of our start and end times. The idea is that we'd be able to fix any issues without going into overtime.

@erri120
Copy link
Member Author

erri120 commented Mar 20, 2024

We could technically further limit the schedule to only run on work days.

@Al12rs
Copy link
Contributor

Al12rs commented Mar 20, 2024

We could technically further limit the schedule to only run on work days.

Yeah, we should do that.
Running before active hours makes sense as it is guaranteed to get the latest stuff from the previous day.
I wouldn't mind moving the other build to before standup, so 14:17 UTC or a bit sooner, as we often have meetings after that and having a build to test the changes of the morning could be useful.

@erri120
Copy link
Member Author

erri120 commented Mar 20, 2024

We could technically further limit the schedule to only run on work days.

Yeah, we should do that. Running before active hours makes sense as it is guaranteed to get the latest stuff from the previous day. I wouldn't mind moving the other build to before standup, so 14:17 UTC or a bit sooner, as we often have meetings after that and having a build to test the changes of the morning could be useful.

Updated to 17 08,14 * * 1-4:

At minute 17 past hour 8 and 14 on every day-of-week from Monday through Thursday

@Sewer56
Copy link
Member

Sewer56 commented Mar 20, 2024

I picked the hours 08 and 15 because it's before most of our start and end times. The idea is that we'd be able to fix any issues without going into overtime.

My train of thought was the exact same when I made the suggestion.

  • From what I heard, most of office starts at 9.00am
  • We work 8 hours per day, not 7 (4x8 in our contracts)
  • Thus most of office should be clocking out at 17:00

I commented, because I thought the end time was actually set too early, rather than too late.
But yeah, standup and morning works for me.

@erri120 erri120 merged commit f2c727f into Nexus-Mods:main Mar 20, 2024
1 check passed
@erri120 erri120 deleted the fix/1079-git-builds-ci branch March 20, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants