Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Required dependency is disabled" diagnostic #1098

Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Mar 20, 2024

No description provided.

@erri120 erri120 added area-game-support Epic: Diagnostics This is related to the Diagnostic System labels Mar 20, 2024
@erri120 erri120 added this to the v0.4 milestone Mar 20, 2024
@erri120 erri120 requested a review from a team March 20, 2024 11:38
@erri120 erri120 self-assigned this Mar 20, 2024
Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 72 lines in your changes are missing coverage. Please review.

Project coverage is 54.24%. Comparing base (52df463) to head (ac9053a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1098      +/-   ##
==========================================
- Coverage   54.35%   54.24%   -0.11%     
==========================================
  Files         671      671              
  Lines       22175    22231      +56     
  Branches     1708     1709       +1     
==========================================
+ Hits        12053    12059       +6     
- Misses       9724     9778      +54     
+ Partials      398      394       -4     
Flag Coverage Δ
Linux 53.56% <0.00%> (-0.10%) ⬇️
Windows 53.50% <0.00%> (-0.10%) ⬇️
clean_environment_tests 54.23% <0.00%> (-0.12%) ⬇️
macOS 52.98% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Games/NexusMods.Games.StardewValley/Diagnostics.cs 0.00% <0.00%> (ø)
...rdewValley/Emitters/DependencyDiagnosticEmitter.cs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@erri120 erri120 merged commit 5300089 into Nexus-Mods:main Mar 20, 2024
5 checks passed
@erri120 erri120 deleted the feat/required-dependency-is-disabled branch March 20, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Diagnostics This is related to the Diagnostic System
3 participants