Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel login after set timeout #1096

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Cancel login after set timeout #1096

merged 2 commits into from
Mar 20, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Mar 20, 2024

No description provided.

@erri120 erri120 requested a review from a team March 20, 2024 11:07
@erri120 erri120 self-assigned this Mar 20, 2024
@Sewer56
Copy link
Member

Sewer56 commented Mar 20, 2024

Consider discussing with Design before merging.

A possible user journey may include:

  • Typing their Password into Password Manager to Get Nexus Password
  • Getting authentication code from authenticator.
    • Either on phone, so phone unlock + check.
    • Or on Desktop.

That can take a while, so the situation can be awkward if the user goes through the whole login process, and finds out things failed because the process timed out.
@erri120 erri120 changed the title Cancel login after 1 minute Mar 20, 2024
@erri120 erri120 merged commit b3a60d6 into Nexus-Mods:main Mar 20, 2024
6 checks passed
@erri120 erri120 deleted the fix/login-timeout branch March 20, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@erri120 @Sewer56 @Al12rs