Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix game updates #1095

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix game updates #1095

merged 1 commit into from
Mar 20, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Mar 20, 2024

Fixes #1093.

@erri120 erri120 added the Bug Something isn't working label Mar 20, 2024
@erri120 erri120 requested a review from Al12rs March 20, 2024 10:47
@erri120 erri120 self-assigned this Mar 20, 2024
Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for the time being.

Down the road, I imagine we'll need to revisit how we store versions, since they can be invalidated by a game update at any time.

Be it invalidating a cached value or reading it from the file dynamically.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.74%. Comparing base (52df463) to head (4d2f207).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
- Coverage   54.35%   53.74%   -0.61%     
==========================================
  Files         671      671              
  Lines       22175    22175              
  Branches     1708     1707       -1     
==========================================
- Hits        12053    11918     -135     
- Misses       9724     9857     +133     
- Partials      398      400       +2     
Flag Coverage Δ
Linux 53.70% <100.00%> (+0.04%) ⬆️
Windows ?
clean_environment_tests 53.74% <100.00%> (-0.60%) ⬇️
macOS 53.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
....StandardGameLocators/GameInstallationConverter.cs 85.18% <100.00%> (+3.70%) ⬆️

... and 33 files with indirect coverage changes

@erri120 erri120 merged commit 6e774bf into Nexus-Mods:main Mar 20, 2024
5 checks passed
@erri120 erri120 deleted the fix/1093-updated-game branch March 20, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
4 participants