Added: A Writer Lock for SqliteDataStore #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sewer56
added
Bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
==========================================
- Coverage 54.59% 54.59% -0.01%
==========================================
Files 669 669
Lines 22024 22037 +13
Branches 1706 1706
==========================================
+ Hits 12023 12030 +7
- Misses 9608 9612 +4
- Partials 393 395 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
erri120
requested changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple writer lock into
SqliteDataStore, such that concurrent access to the database doesn't result in failure.Although we will deprecate the data store I also (just in case) timed the performance of real workloads against this PR. Difference is negligible.
For more details, see #1089
fixes #1089