Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better IDiagnosticWriter API #1085

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Mar 19, 2024

Requires #1082.

  • makes IDiagnosticWriter a singleton
  • requires StringBuilder to be passed as state
@erri120 erri120 added the Epic: Tech-debt Technical debt, this needs solving in the long-term label Mar 19, 2024
@erri120 erri120 requested a review from a team March 19, 2024 15:16
@erri120 erri120 self-assigned this Mar 19, 2024
@erri120 erri120 marked this pull request as ready for review March 20, 2024 09:48
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 22.00000% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 54.27%. Comparing base (a3c2f41) to head (138e259).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
+ Coverage   54.21%   54.27%   +0.06%     
==========================================
  Files         672      671       -1     
  Lines       22211    22200      -11     
  Branches     1713     1714       +1     
==========================================
+ Hits        12042    12050       +8     
+ Misses       9773     9759      -14     
+ Partials      396      391       -5     
Flag Coverage Δ
Linux 53.59% <22.00%> (+0.06%) ⬆️
Windows 53.54% <22.00%> (+0.06%) ⬆️
clean_environment_tests 54.25% <22.00%> (+0.04%) ⬆️
macOS 53.05% <22.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...cs/DiagnosticTemplateIncrementalSourceGenerator.cs 84.71% <100.00%> (+0.09%) ⬆️
src/NexusMods.App.UI/Services.cs 98.77% <100.00%> (-0.01%) ⬇️
...bstractions.Games.Diagnostics/IDiagnosticWriter.cs 0.00% <0.00%> (ø)
...I/Controls/Diagnostics/DiagnosticEntryViewModel.cs 0.00% <0.00%> (ø)
...p.UI/DiagnosticSystem/LoadoutReferenceFormatter.cs 0.00% <0.00%> (ø)
...s.App.UI/DiagnosticSystem/ModReferenceFormatter.cs 0.00% <0.00%> (ø)
...Mods.App.UI/DiagnosticSystem/NamedLinkFormatter.cs 0.00% <0.00%> (ø)
.../Diagnostics/Details/DiagnosticDetailsViewModel.cs 0.00% <0.00%> (ø)
...rols/Diagnostics/DiagnosticEntryDesignViewModel.cs 0.00% <0.00%> (ø)
...sMods.Abstractions.Games.Diagnostics/Diagnostic.cs 26.92% <0.00%> (-4.90%) ⬇️
... and 1 more

... and 4 files with indirect coverage changes

Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does exactly as says on the tin

@erri120 erri120 merged commit a3ede45 into Nexus-Mods:main Mar 20, 2024
8 of 9 checks passed
@erri120 erri120 deleted the fix/better-writer branch March 20, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Tech-debt Technical debt, this needs solving in the long-term
3 participants