Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Title to Diagnostics #1073

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Mar 18, 2024

As discussed in a meeting last week, this adds a Title property to Diagnostic.

@erri120 erri120 added this to the v0.4 milestone Mar 18, 2024
@erri120 erri120 requested a review from a team March 18, 2024 09:15
@erri120 erri120 self-assigned this Mar 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 55.05%. Comparing base (c499846) to head (9975ac1).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1073      +/-   ##
==========================================
+ Coverage   54.84%   55.05%   +0.20%     
==========================================
  Files         662      660       -2     
  Lines       22022    21954      -68     
  Branches     1710     1702       -8     
==========================================
+ Hits        12079    12087       +8     
+ Misses       9549     9469      -80     
- Partials      394      398       +4     
Flag Coverage Δ
Linux 54.36% <54.54%> (+0.19%) ⬆️
Windows 54.24% <54.54%> (+0.16%) ⬆️
clean_environment_tests 55.04% <54.54%> (+0.21%) ⬆️
macOS 53.80% <54.54%> (+0.17%) ⬆️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...sMods.Abstractions.Games.Diagnostics/Diagnostic.cs 70.00% <100.00%> (+3.33%) ⬆️
...ons.Games.Diagnostics/DiagnosticTemplateBuilder.cs 0.00% <ø> (ø)
...ountAndBlade2Bannerlord/Emitters/BuiltInEmitter.cs 58.22% <100.00%> (+0.53%) ⬆️
...Tests/Diagnostics/DummyLoadoutDiagnosticEmitter.cs 0.00% <0.00%> (ø)
...del.Tests/Diagnostics/DummyModDiagnosticEmitter.cs 0.00% <0.00%> (ø)
...cs/DiagnosticTemplateIncrementalSourceGenerator.cs 81.17% <83.33%> (+0.02%) ⬆️
...aModel.Tests/Diagnostics/DiagnosticManagerTests.cs 0.00% <0.00%> (ø)
...Games/NexusMods.Games.StardewValley/Diagnostics.cs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@erri120 erri120 merged commit 4f6caba into Nexus-Mods:main Mar 18, 2024
6 checks passed
@erri120 erri120 deleted the feat/diagnostic-title branch March 18, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants