Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single UnifiedIcon in Advanced Installer Views #1057

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Mar 13, 2024

This tiny PR brings makes the AdvancedInstaller's icon presentation strategy to match the strategy used in the new View Mod Files functionality.

i.e. Applying ViewModFiles PR Feedback to Advanced Installer

I.e. We now no longer hide icons, but swap them out.

@Sewer56 Sewer56 requested a review from a team March 13, 2024 08:59
@Sewer56 Sewer56 self-assigned this Mar 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.39%. Comparing base (5a6319b) to head (2b90dc4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   55.38%   55.39%           
=======================================
  Files         659      659           
  Lines       21886    21886           
  Branches     1709     1709           
=======================================
+ Hits        12122    12123    +1     
  Misses       9364     9364           
+ Partials      400      399    -1     
Flag Coverage Δ
Linux 54.72% <ø> (+0.07%) ⬆️
Windows 54.65% <ø> (+0.08%) ⬆️
clean_environment_tests 55.37% <ø> (ø)
macOS 54.09% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@erri120 erri120 changed the title Updated: Advanced Installer Views to use Single UnifiedIcon Mar 13, 2024
@Sewer56 Sewer56 merged commit 23f2aa9 into main Mar 13, 2024
4 of 5 checks passed
@erri120 erri120 deleted the single-unifiedicon-in-advancedinstaller branch March 27, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants