Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GetDefaultOpenPageBehavior #1052

Merged
merged 10 commits into from
Mar 13, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Mar 12, 2024

Part of #946. This PR implements the flowchart we developed earlier and most of #946.

@erri120 erri120 added the Epic: Workspace System This is related to the Panels/Workspace system label Mar 12, 2024
@erri120 erri120 added this to the v0.4 milestone Mar 12, 2024
@erri120 erri120 requested a review from Al12rs March 12, 2024 13:53
@erri120 erri120 self-assigned this Mar 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 12.26994% with 143 lines in your changes are missing coverage. Please review.

Project coverage is 55.16%. Comparing base (021e5a1) to head (07acaa9).
Report is 6 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
+ Coverage   54.78%   55.16%   +0.37%     
==========================================
  Files         659      662       +3     
  Lines       21886    21992     +106     
  Branches     1709     1717       +8     
==========================================
+ Hits        11990    12131     +141     
+ Misses       9492     9460      -32     
+ Partials      404      401       -3     
Flag Coverage Δ
Linux 54.45% <12.26%> (-0.34%) ⬇️
Windows 54.38% <12.26%> (?)
clean_environment_tests 55.14% <12.26%> (+0.36%) ⬆️
macOS 53.94% <12.26%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...usMods.App.UI/WorkspaceSystem/Page/IPageFactory.cs 86.36% <100.00%> (+1.36%) ⬆️
...p.UI/WorkspaceSystem/Page/PageFactoryController.cs 52.38% <100.00%> (+5.01%) ⬆️
...paceSystem/WorkspaceController/AddPanelBehavior.cs 66.66% <ø> (ø)
...Mods.App.UI/WorkspaceSystem/Page/APageViewModel.cs 93.33% <0.00%> (-6.67%) ⬇️
...UI/WorkspaceSystem/Workspace/WorkspaceViewModel.cs 48.43% <0.00%> (+0.74%) ⬆️
...paceSystem/WorkspaceController/OpenPageBehavior.cs 0.00% <0.00%> (ø)
...Mods.App.UI/LeftMenu/Home/HomeLeftMenuViewModel.cs 66.66% <50.00%> (+4.16%) ⬆️
...c/NexusMods.App.UI/WorkspaceSystem/PageIdBundle.cs 0.00% <0.00%> (ø)
...I/LeftMenu/Downloads/DownloadsLeftMenuViewModel.cs 0.00% <0.00%> (ø)
...pp.UI/LeftMenu/Loadout/LoadoutLeftMenuViewModel.cs 0.00% <0.00%> (ø)
... and 3 more

... and 35 files with indirect coverage changes

Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

@erri120 erri120 force-pushed the feat/946-open-page-behavior branch from b586a27 to 0921e8a Compare March 12, 2024 16:25
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@Al12rs
Copy link
Contributor

Al12rs commented Mar 12, 2024

Closing and reopening to update target of the diff

@Al12rs Al12rs closed this Mar 12, 2024
@Al12rs Al12rs reopened this Mar 12, 2024
@erri120 erri120 requested a review from Al12rs March 13, 2024 09:26
@Al12rs Al12rs merged commit 67a23d2 into Nexus-Mods:main Mar 13, 2024
6 checks passed
@erri120 erri120 deleted the feat/946-open-page-behavior branch March 13, 2024 12:22
@Al12rs
Copy link
Contributor

Al12rs commented Mar 13, 2024

I'm sorry I'm slipping, I meant to test this locally with the View Mod contents.
I just checked the code and LoadoutGridViewModel is using a custom behavior instead of GetDefaultBehavior.
Could you do another PR to fix that? Or I can add it to the list if you are busy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Workspace System This is related to the Panels/Workspace system
3 participants