Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dep updates #1051

Merged
merged 7 commits into from
Mar 12, 2024
Merged

Dep updates #1051

merged 7 commits into from
Mar 12, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Mar 12, 2024

Built, ran tests, opened the App played around a bit to check for obvious issues, didn't notice any problems.

@Al12rs Al12rs requested a review from a team March 12, 2024 13:08
@Al12rs Al12rs self-assigned this Mar 12, 2024
@erri120
Copy link
Member

erri120 commented Mar 12, 2024

The Microsoft.CodeAnalysis.CSharp.* packages are somewhat special in that they are directly tied to the Roslyn version used during compilation. I don't think there are any issues with upgrading to latest since we're using .NET 8.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.32%. Comparing base (22f2296) to head (aef9588).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
+ Coverage   56.29%   56.32%   +0.02%     
==========================================
  Files         648      648              
  Lines       21489    21489              
  Branches     1670     1670              
==========================================
+ Hits        12097    12103       +6     
+ Misses       8990     8986       -4     
+ Partials      402      400       -2     
Flag Coverage Δ
Linux 55.66% <ø> (+0.02%) ⬆️
Windows 55.54% <ø> (+0.02%) ⬆️
clean_environment_tests 56.30% <ø> (+0.02%) ⬆️
macOS 55.05% <ø> (+0.01%) ⬆️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@Al12rs Al12rs merged commit 9e95f17 into main Mar 12, 2024
5 checks passed
@Al12rs Al12rs deleted the dependency_updates branch March 12, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants