Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spine items active state improvements #1047

Merged
merged 8 commits into from
Mar 12, 2024
Merged

Spine items active state improvements #1047

merged 8 commits into from
Mar 12, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Mar 11, 2024

  • Cleanup of how the Active Spine item is tracked
    • Added an interface for Spine items
    • Removed Tag stuff
    • Keep track of active item if loadout list changes
  • Removed some old dead code
  • Fixed the TopBar Action buttons disabled styles

Ticked a couple of items on #906
@Al12rs Al12rs requested a review from a team March 11, 2024 16:39
@Al12rs Al12rs self-assigned this Mar 11, 2024
Sewer56
Sewer56 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Sewer56 Sewer56 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through the code, seems fine to me.

I haven't dug down to the nitty gritty, i.e. actually debugging it to see it live in action, but it LGTM (TM)
@Al12rs
- Use ReactiveCommand,
7957f47 
- Remove unused initializers,
- Add Empty Reactive command initializer,
- Move reactive command creation outside WhenActivated
@Al12rs Al12rs requested a review from erri120 March 12, 2024 09:55
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.06452% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 56.31%. Comparing base (ccf4f22) to head (83ece82).
Report is 15 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1047      +/-   ##
==========================================
+ Coverage   55.64%   56.31%   +0.67%     
==========================================
  Files         649      648       -1     
  Lines       21491    21489       -2     
  Branches     1671     1670       -1     
==========================================
+ Hits        11958    12101     +143     
+ Misses       9133     8987     -146     
- Partials      400      401       +1
Flag Coverage Δ
Linux 55.65% <83.06%> (+0.10%) ⬆️
Windows 55.45% <83.06%> (∅)
clean_environment_tests 56.29% <83.06%> (+0.67%) ⬆️
macOS 54.99% <83.06%> (+0.06%) ⬆️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/Buttons/Download/SpineDownloadButtonViewModel.cs 100.00% <100.00%> (ø)
...Controls/Spine/Buttons/Icon/IconButtonViewModel.cs 100.00% <100.00%> (ø)
.../Spine/Buttons/Image/ImageButtonDesignViewModel.cs 0.00% <ø> (ø)
...ntrols/Spine/Buttons/Image/ImageButtonViewModel.cs 100.00% <100.00%> (ø)
src/NexusMods.App.UI/Initializers.cs 100.00% <100.00%> (+40.00%) ⬆️
...s/Download/SpineDownloadButtonDesignerViewModel.cs 47.61% <50.00%> (-2.39%) ⬇️
...Mods.App.UI/Controls/Spine/SpineDesignViewModel.cs 0.00% <0.00%> (ø)
.../NexusMods.App.UI/Controls/Spine/SpineViewModel.cs 72.00% <83.33%> (+7.29%) ⬆️

... and 32 files with indirect coverage changes
@erri120 erri120 merged commit 22f2296 into main Mar 12, 2024
6 checks passed
@erri120 erri120 deleted the spine_and_layout_improvements branch March 12, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@Al12rs @codecov-commenter @Sewer56 @erri120